Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dev/core#223) Expose prefix and suffix in reports #12394

Merged
merged 1 commit into from
Jul 3, 2018
Merged

(dev/core#223) Expose prefix and suffix in reports #12394

merged 1 commit into from
Jul 3, 2018

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Jul 2, 2018 •
edited
Loading

Overview

Add prefix and suffix to getContactColumns method.

Before

prefix_before

After

pre_after

@civibot
Copy link

civibot bot commented Jul 2, 2018

(Standard links)

@yashodha
Copy link
Contributor Author

yashodha commented Jul 2, 2018

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

I'm ok sneaking this through without a test - just need to check the output

@eileenmcnaughton
Copy link
Contributor

OK - I tested this & it works well.

Note that only reports that use that fn will get the additional fields (hopefully one day that will be all of them)

@eileenmcnaughton eileenmcnaughton merged commit 6673795 into civicrm:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashodha @eileenmcnaughton @civicrm-builder