Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core/issues/202, check if default currency is set #12356

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

pradpnayak
Copy link
Contributor

Overview

This is something i noticed on drupal7, CiviCRM 5.2.1 fresh install where i don't have default currency set under(Settings - Localization). The currency field on New Contribution and elsewhere shows an empty option

Before

before

After

after

Technical Details

Added condition to check if default currency is set or not

@civibot
Copy link

civibot bot commented Jun 22, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@mattwire FYI - this is a minor regression introduced in 5.0 by this commit b740ee4

I only do regression analysis on things that worked in 5.0 and then regressed so I won't do it here but to be honest I think this one might just be 'one of those things'

@pradpnayak thank you very much for picking this up and fixed it. I had noticed it (but only last week) but had not dug in and I completely agree with your fix.

@eileenmcnaughton eileenmcnaughton merged commit af52a18 into civicrm:master Jul 1, 2018
@pradpnayak pradpnayak deleted the issue-202 branch July 24, 2018 11:21
kenwest added a commit to kenwest/cbf-drupal that referenced this pull request Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants