(NFC) CiviUnitTestCase - Fix edge-case for mis-reported error #12347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose you run a test and it encounters an error very early in process -- e.g. while processing `setUp()`, before constructing the instance of `$this->hookClass`. It then proceeds to `tearDown()`. Later, the test runner will give you a report on the rrors. Before ------------ The `tearDown` fails because the missing instance of `$this->hookClass` raises another error, and test-report shows this misleading reference. After ------------ The `tearDown` proceeds, and the test-report shows the real cause of the failure.
|
(Standard links)
|
totten
changed the title
|
I'm biased, but I'd argue this is NFC because the change doesn't affect runtime behavior, and it doesn't change test-semantics. It tweaks the test framework. |
|
giving this merge on pass as agree with the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose you run a test and it encounters an error very early in process --
e.g. while processing
setUp(), before constructing the instance of$this->hookClass. It then proceeds totearDown(). Later, the testrunner will give you a report on the error(s).
This fixes the reporting of the error.
Before
The
tearDownfails because the missing instance of$this->hookClassraises another error, and test-report shows this misleading reference.
After
The
tearDownproceeds, and the test-report shows the real causeof the failure.