(dev/core#174) api_v3_SettingTest - Remove dead code #12321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unit is clearing out a non-existent cache item. To see that it is non-existent, I grepped (case-insensitive) for
the expressions:
* `CiviCRM setting Spec`
* `CiviCRM setting `
* `setting spec`
This feels like left-overs from 4.6. In 4.7, the setting cache was reworked. Note that
`SettingTest` does clear newer cache (`Civi::cache('settings')->flush();`).
|
(Standard links)
|
|
Merging as per tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This unit test is clearing out a non-existent cache item. It's dead-code.
Before
SettingTestclearsCiviCRM setting Spec, which is never populated anywayAfter
CiviCRM setting Spechas disappeared from the face of the Earth.Technical Details
To see that it the cache item is non-existent, I grepped (case-insensitive) for the expressions:
CiviCRM setting SpecCiviCRM settingsetting specThis feels like left-overs from 4.6. In 4.7, the setting cache was reworked. Note that
SettingTestdoes clear the newer cache (Civi::cache('settings')->flush();).