Fix for #180: passing the entity ID to the custom hook when deleting a custom value #12309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When deleting a custom value record from a multiple custom data set. The entityId is not passed to the hook civicrm_custom. This causes some weird behaviours in extensions (for example CiviRules, see: https://github.com/CiviCooP/org.civicoop.civirules/issues/208
See https://lab.civicrm.org/dev/core/issues/180
Before
Upon deleting a custom value
$entityID
parameter of the hook civicrm_custom is not set.After
Upon deleting a custom value
$entityID
parameter of the hook civicrm_custom is set to the right value..