Use try catch when deleting groups (dev/core/issues/22 ) #11826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
1 similar comment
|
test this please |
|
@colemanw @seamuslee001 are one of you happy to merge this - per comments above I'm happy to close this if it can't be agreed easily. |
|
@eileenmcnaughton This looks sensible to me. We don't care if a count fails if we're trying to delete something and it's just this kind of thing that spoils the end-user perception of CiviCRM when it goes wrong! |
|
I'm going to merge based on @mattwire endorsement. This is safe IMHO & needs to not take up any more of my time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prevent fatal error on deleting broken smart group
Before
Error when deleting broken smart group
After
Presumable no error - see below.
Technical Details
Comments
@KarinG hit a bug when one of her customers could not delete broken smart groups. I suggested using the try-catch block on chat. However, Karin only tried commenting out this line so did not confirm whether the try-catch works. I was on the fence about putting this up as a PR since I don't think the bug rises to the level of it being an important use of volunteer time & I could not justify the time involved either for myself or a reviewer trying to replicate it.
OTOH I think it's pretty harmless & safe, and I had already sunk time into it on the support channel