CRM-21779 - ang\crmMailing - Fix adding empty mailing to recipients field

[lemacarl]

Overview

This PR prevents CiviMail from adding mailing lists including draft and unscheduled mailings that do not have any recipients

Before

After

Technical Details

Add chain rule to Mailing getlist api call to include MailingRecipients getcount then filter civicrm_mailing options by api.MailingRecipients.getcount

Comments

Anything else you would like the reviewer to note

---

• CRM-21779: Civimail allows adding current draft mailing recipients to recipients field

[totten]

I haven't really reviewed this, but on a policy/usability level -- @lemacarl this seems like a good idea.

[jitendrapurohit]

Instead of the above if condition, can this be removed and adjusted in the above "case" section? Something like -

var filterParams = recipients = {}; //Initialize.
.
.
case 'civicrm_mailing':
  filterParams = { is_hidden: 0, is_active: 1 };
  recipients["api.MailingRecipients.getcount"] = {}; //Add chain api param
  break;
}
var params = {
  input: input,
  page_num: rcpAjaxState.page_i,
  params: filterParams,
};
$.extend(params, recipients); //Merge to the main param

[jitendrapurohit]

@eileenmcnaughton @totten This is working as expected on the mailing screen. Those having empty recipients are removed from the dropdown list correctly. Though there is a minor scope of improvement from code POV, but does not seem necessary to block the merging of this PR.

[eileenmcnaughton]

thanks @jitendrapurohit