Add test for processing multipart-related emails in fetch_bounces #11378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
test
branch
2 times, most recently
from
86daf76 to
9c98c0a
Compare
totten
reviewed
Dec 6, 2017
| * | ||
| * @param string $dir | ||
| */ | ||
| protected function rrmdir($dir) { |
There was a problem hiding this comment.
There's a utility function CRM_Utils_File::cleanDir($dir, TRUE, FALSE) which should be pretty similar. I'm not sure if there's some intentional/significant difference here -- but, FWIW, I've used it in other tests (like CRM_Extension_Manager_ModuleTest).
There was a problem hiding this comment.
@totten yep - that function worked
|
Generally, a big +1 for the idea of adding example email messages to the test suite. This seems pretty important for email-based interactions. |
I was trying to replicate an error but didn't manage. Submitting test
eileenmcnaughton
force-pushed
the
test
branch
from
9c98c0a to
e7693dd
Compare
|
Looks good+sensible. I pushed a small tweak to the branch. Merge on pass. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
Add test for processing multipart-related emails in fetch_bounces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to replicate an error but didn't manage. Submitting test