CRM-21482 follow up notice fix - sync function signatures on getCurrency #11344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng abstract payment class. I'd really have liked to removed $submittedValues from the AbstractEditPayment class but it felt too risky since there are a lot of unpredictable params in there. Only CRM_Contribute_Form_Contribution actually calls that line.
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21482 follow up notice fix - sync function signatures on getCurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a warning by syncing function signatures
Before
On back office contribution:
Warning: Declaration of CRM_Contribute_Form_AbstractEditPayment::getCurrency($submittedValues) should be compatible with CRM_Core_Form::getCurrency() in require_once() (line 48 of /Users/emcnaughton/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Contribute/Form/AbstractEditPayment.php).
After
Msg fixed
Technical Details
I'd really have liked to removed $submittedValues from the AbstractEditPayment class
but it felt too risky since there are a lot of unpredictable params in there.
Only CRM_Contribute_Form_Contribution actually calls that line.
Comments
@colemanw follow up on the patch you merged the other day