[NFC] code cleanup: split out 2 functions that are mostly unrelated. #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
towards1
branch
from
76109b1 to
891b879
Compare
|
test this please |
|
@monishdeb another nfc subset of #10962 |
|
@eileenmcnaughton you have 2 style issues https://test.civicrm.org/job/CiviCRM-Core-PR/18057/checkstyleResult/new/ |
The handling of line items & financial items has been munged together in a way that gains little, adds confusion, and blocks the financial items portion from being re-usable. This is a code cleanup preparatory to the actual changes in pr civicrm#10962
eileenmcnaughton
force-pushed
the
towards1
branch
from
891b879 to
ed0cb2f
Compare
|
thanks @seamuslee001 -hopefully fixed now |
|
Note if anyone wants to review this I think the easiest steps are actually to redo the refactor & see if you get the same results. Basically I copied the function & renamed it & then changed the second place to call the second function. Once you start pulling out parameters that are no longer required it kinda falls into place |
|
little green tick |
|
Merging based on code review. I see that there are a few unit tests calling |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
[NFC] code cleanup: split out 2 functions that are mostly unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup only
Before
One function does 2 very different things depending on one parameter
After
Function is split into 2
Technical Details
The handling of line items & financial items has been munged together in a way that gains little, adds confusion,
and blocks the financial items portion from being re-usable.
This is a code cleanup preparatory to the actual changes in pr #10962