-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-21426: Removed duplicate submit buttons on Cancel/Delete Event Participants #11277
Conversation
Can one of the admins verify this patch? |
@mihaelmladenov Thanks for the patch. Can you open a JIRA issue on https://issues.civicrm.org? This is necessary so that the change gets correctly logged in the Release Notes. c.f. https://docs.civicrm.org/dev/en/latest/core/contributing/ |
jenkins, test this please |
Hi Mathieu,
I just registered at the site and am pending approval. Can you approve it and I will create the JIRA
issue after that. Thanks!
Best regards,
Mihael
…On 14 November 2017 at 16:19, Mathieu Lu ***@***.***> wrote:
jenkins, test this please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11277 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APeN-4SLjHT7RZ2jNHR_oi6_s0S9QNd8ks5s2aFzgaJpZM4QdScr>
.
|
@mihaelmladenov done! |
@mlutfy Thanks. I've created one: |
I tested this patch (on http://core-11277-19jsu.test-ubu1204-5.civicrm.org). @mihaelmladenov Could you also fix the "Delete Participants" action? |
@mlutfy This is now done and pushed. |
Jenkins ok to test |
@mihaelmladenov That's a good improvement too, but I was talking about the "Delete Participants" action, it still has the top buttons as well: Otherwise we're creating an inconsistency, by having Cancel and Delete behave differently. |
@mlutfy This is now also fixed. |
…ent-participants CRM-21426: Removed duplicate submit buttons on Cancel/Delete Event Participants
Overview
This PR solves an inconsistency with other confirmation pages which only have one set of buttons instead of two. It removes the buttons at the top of the Cancel Event Participants and Delete Event Participants pages and also changes the title of the submit button from "Continue" to "Cancel Registrations" on the Cancel Event Participants page.
Steps to get to the page:
Screenshots
Before:
After:
Technical Details
This PR alters the
templates/CRM/Event/Form/Task/Cancel.tpl
file to remove the HTML for the buttons at the top of the form.It also alters the
CRM/Event/Form/Task/Cancel.tpl
file to change the title of the submit button.Comments
Please review and merge to the master branch.