Skip to content

CRM-21389 Added pre and post regions to each entitys userdashboard #11235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

clnlf
Copy link
Contributor

@clnlf clnlf commented Nov 3, 2017

Overview

Adds pre and post regions to each entity's userdashboard for developer injection

Before

NA

After

NA

Technical Details

Example:
File civicrm/templates/CRM/Contribute/Page/PcpUserDashboard.tpl

{crmRegion name="crm-contribute-pcp-userdashboard-pre"}
{/crmRegion}

Comments

Doubt: Do smarty templates require an empty line at the end of them?


@civicrm-builder
Copy link

Can one of the admins verify this patch?

@clnlf clnlf changed the title Added pre and post regions to each entitys userdashboard CRM-21389 Added pre and post regions to each entitys userdashboard Nov 3, 2017
@seamuslee001
Copy link
Contributor

Jenkins ok to test

@eileenmcnaughton
Copy link
Contributor

This feels consistent with other changes to add regions and should have no obvious impact. Can you please do a PR to the https://github.com/civicrm/civicrm-dev-docs repo to document these regions

@eileenmcnaughton eileenmcnaughton merged commit 43aeabc into civicrm:master Nov 22, 2017
@clnlf
Copy link
Contributor Author

clnlf commented Nov 22, 2017

eileenmcnaughton commented 11 hours ago
This feels consistent with other changes to add regions and should have no obvious impact. Can you please do a PR to the https://github.com/civicrm/civicrm-dev-docs repo to document these regions

Sure thing. Thanks!

@clnlf
Copy link
Contributor Author

clnlf commented Nov 22, 2017

Documented changes at dev docs https://github.com/civicrm/civicrm-dev-docs/pull/450

@eileenmcnaughton
Copy link
Contributor

Thanks! I appreciate you doing it after merge since I know the pressure if off once merge is completed

sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
…egions

CRM-21389 Added pre and post regions to each entitys userdashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants