CRM-20892 Fix up issue where created_date may not have yet been conve… #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted to timestamp so should stay as datetime in upgrade
|
Agree -- preserving the column data-type is more consistent with our general posture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rted to timestamp so should stay as datetime in upgrade
Overview
Previously the upgrade would just set the column datatype to be timestamp which may or may not be 100% correct as the end user may or may not have run the doctor when conversion yet. This re-uses some of the doctorWhen status notice stuff to check if it is a datetime or timestamp column and then uses that in the altertable statement
@totten @eileenmcnaughton Tim i believe this will address your concerns raised at the sprint. putting this against the RC as its an issue in 4.7.27 due to be released in November