CRM-19850 - Add a offline membership without 'record payment' option,…

[yashodha]

… later edit the membership and saving with 'record payment' option

Overview

1. Visit any contact, and click on membership tab.
2. Click on 'Add Membership', select the desired membership, and uncheck 'record payment' option, save it.
3. Now, edit the same membership, and this time check the 'record payment' checkbox, the payment details form doesn't appear.
4. Trying to save this screen, results in 'Please select Financial Type' form error message.

Before

[yashodha]

@jitendrapurohit can you please look at this?

[eileenmcnaughton]

I tested this & replicated the bug and was able to see that this fixes the bug. The code change is small and targetted & I feel confident it won't affect other things.

I think this is a short term fix, as we move to replace this with the payment block, but definitely a fix worth having, merging