CRM-21175 fix fatal error on multiple custom field import. #10975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
4.7.25-rc
branch
from
ef104ee to
268887c
Compare
Additional test is tangental....
eileenmcnaughton
force-pushed
the
4.7.25-rc
branch
from
268887c to
412585f
Compare
|
@seamuslee001 can you re-test this - I just checked on http://core-10975-7apms.test-ubu1204-5.civicrm.org/civicrm/import/custom & it is OK (it wasn't earlier & the change I made in between was just is_reserved => 1 |
|
Re-tetested on a separate local install, confirmed fatal error, applied patch fatal error goes away and form is shown |
|
Thanks @seamuslee001 - just trying to get someone else to merge it now - note this is a recent regression (although no user picked it up & it is in slightly obscure functionality, I only noticed it through trying to replicate another issue for PR review). Hence rc merge |
|
Seamus's testing sounds proportionate. Thanks to both of you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test is tangental....
Overview
Fixes fatal error on attempting to import multiple custom data values
Before
civicrm/import/custom returns CiviCRM_API3_Exception: "'Import Multi value custom data' is not a valid option for field mapping_type_id"
After
Page loads correctly
Technical Details
Recent changes caused this to go from silent weird behaviour to a hard fail. I have gone with an ad-hoc creating of the option rather than in import in case other imports (including external) are impacted.