CRM-21113: find case - search by id, subject

[lcdservices]

Overview

Include Case ID and Case Subject in Find Cases tool

Technical Details

This PR also cleans up the Find Case layout. It is built on a table structure but had an inconsistent number of columns in certain rows depending on what fields were potentially displayed. This implements a consistent three column layout. It also removes some duplicate label tags.

---

• CRM-21113: find cases: search by case ID and subject

[monishdeb]

The added new columns ID and subject are working on new 'Find Case' search form. Here's the layout after applying patch:

However, there are few changes I'd like to add:

1. The Case subject field is too wide, as result of which the tag field is cornered below.
2. Although it's not relevant to the issue but what if we replace the case_tags form element with colored Tag tree select2 that is already used in various places.
3. Add unit test (ref - https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/CRM/Contact/BAO/QueryTest.php)

For 1 and 2 I have prepared a patch - https://gist.github.com/monishdeb/bee2ebc02267061bb847bf6d989f8640
And screenshot after the change:

[lcdservices]

I agree we should use the select2 widget -- that's a good improvement. Re: subject line -- I think it's more usable when wider. I merged table cells so that it can remain wide without squeezing the tag field. PR has been updated.

[monishdeb]

Looks great, also checked the underlying query, all working great. Will add unit-test for necessary filters on 'Find Case' search form. Merging now.