CRM-21078 Allow user to save and continue editing message template #10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Before this change, message template used to throw validation error on not filling the required field title -
This is no longer happening now and an empty template is saved with message The Message Template 'null' has been saved. To replicate - Apply this PR -> Add message template and save without filling any field.
mattwire
force-pushed
the
CRM-21078_message_template_form
branch
from
de7252e to
b93376a
Compare
|
Tested, working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow the user to continue editing a message template without exiting and then reopening the message template.
Buttons when editing message template are now (matching other workflows in CiviCRM, eg. create/edit event)
Save | Save and Done | Cancel
Additionally, cleanup FIXME, redundant code and improve performance of existing code.