Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21055, Change the label of cancel button to close on Contribution form #10845

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

pradpnayak
Copy link
Contributor


Overview

Change the label of cancel button to close on Contribution form

Before

before

After

after

----------------------------------------
* CRM-21055: Change label of cancel button
  https://issues.civicrm.org/jira/browse/CRM-21055
@monishdeb
Copy link
Member

monishdeb commented Aug 10, 2017

@eileenmcnaughton @colemanw I will be merging this PR as this is just a label change.

@eileenmcnaughton
Copy link
Contributor

Actually @monishdeb I think you should hold off & get @colemanw to double check this one. Technically it is trivial - but it's not clear to me if anyone would have a different opinion about the wording change (personally I'm neutral)

@colemanw
Copy link
Member

Well, that button won't make much sense in a non-popup context. "Cancel" is the standard wording for pretty much all popups to close without saving.

@colemanw
Copy link
Member

I'm guessing the motivation for this change is to disambiguate between cancelling a contribution, and closing the form without saving. Is that correct?
Can you give more details about where/how this is ambiguous in the current UI?

@monishdeb monishdeb closed this Aug 10, 2017
@monishdeb monishdeb reopened this Aug 10, 2017
@lcdservices
Copy link
Contributor

I think Close is more meaningful and less confusing. Close suggests no action is taking place -- which is what's actually happening. Cancel could have other connotations in this context.

@agileware
Copy link
Contributor

Agree with @lcdservices "close" is a better term in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants