CRM-21049 - Allow creating relationship types with no contact type specified #10839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The API currently doesn't allow creating a relationship type with contact type of "All Contacts". This is intended to fix this.
Before
The API create spec defines
contact_type_a
andcontact_type_b
as required, and locks this functionality in via a unit test.After
I removed the lines from the spec and removed/updated the unit tests locking in the incorrect behavior.
Comments
This code hasn't been touched since Civi was migrated from SVN to git - so it might be that once upon a time there was no way to specify "All Contacts" via leaving
contact_type_a
orcontact_type_b
as NULL.