CRM-20800 : User Cannot Cancel Recurring Payment With Paypal #10833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb - this fix seems to make it so that a bad works a little bit better but it doesn't feel like a fix. It seems like we are in a path where we have the recurring contribution id so we must know the payment processor id & should be able to use a reliable function like getProcessorByID rather than this 'do you feel lucky punk' function |
|
(as an aside why was this against the rc - it doesn't look like a regression?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The recurring contribution could not be cancelled.
However, if you are logged in and deselect "Notify Paypal" you are able to cancel the recurring payment. It only seems to fail when that box is checked.
Comments
It throws notice error on dblog as
Undefined index: payment_processor_type in CRM_Core_Payment_PayPalImpl->cancelSubscription() (line 663 of /var/www/html/sitename/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php)