CRM-17157 support multiple decimalplaces formrule money #10827
Conversation
…es such as bitcoin, also helps towards CRM-20772 which requires higher precision decimals to be stored in the database to calculate tax inclusive amounts correctly
|
Jenkins, test this please |
|
@eileenmcnaughton - I believe you mentioned you're already doing this for WMF? I like it when we can note real world experience on PRs. It would put you in the best position to ok this. |
|
@KarinG we did it slightly differently for WMF - the regex is (^-?\d+.?\d*$)|(^-?\d*.\d+$). However, I don't think that difference is material & the tests look good. I tried a few more over here http://regexr.com - mostly to check lack of preceding number ie. .35678 -.35678 0.35678 -0.35678 & they all worked. I'm going to merge because we have agreed (on the other PR) that this change makes sense to do & the test @mattwire wrote is really good & gives us great cover. From what I've seen mysql still trims decimal places if the field does not support more than 2 places. @mattwire wins the star of the day prize for the test! |
|
(note that I feel the regex is still safe in that it does not permit any characters other than digits, dots & +/- indicator & currency |
|
Awesome - all done this one. |
mattwire
deleted the
CRM-17157_support_multiple_decimalplaces_formrule_money
branch
Ref CRM-20772 and CRM-17157. CRM_Utils_Rule::money currently assumes all currencies have 2 decimal places (this is not true, eg. bitcoin). Also to allow proper calculation of tax where the tax inclusive amount should be a round number we have to save more than 2 decimal places in the database. This is part of that puzzle!
I've also added a unit test :-)
@eileenmcnaughton