CRM-21027 Fix next recurring payment not accurately calculated #10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffective date passed in
eileenmcnaughton
force-pushed
the
recur_date
branch
from
5258fac to
46f459f
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
commented
Aug 4, 2017
| @@ -99,15 +99,15 @@ public function testCancelRecur() { | |||
| */ | |||
| public function testSupportFinancialTypeChange() { | |||
| $contributionRecur = $this->callAPISuccess('contribution_recur', 'create', $this->_params); | |||
| $contribution = $this->callAPISuccess('contribution', 'create', array( | |||
| $this->callAPISuccess('contribution', 'create', array( | |||
There was a problem hiding this comment.
these changes are unrelated - I noticed these minor errors while looking in the wrong file
|
In 'before' it says "as customers will be recharged". Is there a 'not' missing from that statement |
|
@petednz no - there isn't! I narrowly avoiding multi-charging yes customers due there being another bug in the Omnipay extensions meaning they weren't charged at all for 4 days |
|
The fix makes sense. Tested, working fine. Also the added use-case in unit test is accurate. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes a bug that entered the code base in May, causing payment processors that rely on CiviCRM updating the next_sched_contribution_date for recurring to not get it updated.
Before
When payments are completed using the completetransaction api with a receive_date passed in with a time component the date for the next scheduled contribution is not updated. This is a critical error to sites affected as customers will be recharged, but mitigated by the fact that relatively few use the combination of components (in my case DPS / Omnipay + recurring payments)
After
After processing a payment the next_sched_contribution_date is correctly updated
Technical Details
Rather than comparing effectiveDate with today, the date part of effectiveDate ('Y-m-d') is compared with today
Comments
I was able to replicate this in a unit test before fixing it & committing the test