CRM-20947, fixed notice error on Activity tab #10788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-20947: Remove Deprecation Notice for Option group https://issues.civicrm.org/jira/browse/CRM-20947
CRM/Activity/BAO/Activity.php
Outdated
| @@ -2373,7 +2373,10 @@ public static function createFollowupActivity($activityId, $params) { | |||
| $followupParams = array(); | |||
| $followupParams['parent_id'] = $activityId; | |||
| $followupParams['source_contact_id'] = CRM_Core_Session::getLoggedInContactID(); | |||
| $followupParams['status_id'] = CRM_Core_OptionGroup::getValue('activity_status', 'Scheduled', 'name'); | |||
| $followupParams['status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Activity_BAO_Activity', | |||
| 'activity_status', | |||
There was a problem hiding this comment.
shouldn't this be status_id
There was a problem hiding this comment.
Oops sorry.. Not sure how i missed that. Pushed the change.
|
first one looks wrong, others look right |
---------------------------------------- * CRM-20947: Remove Deprecation Notice for Option group https://issues.civicrm.org/jira/browse/CRM-20947 fixed fieldname
|
I thought that last one was wrong & it should be just status_id - however grepping says CRM_Core_PseudoConstant::getKey('CRM_Activity_BAO_Activity', 'activity_status_id', 'Completed'), These are simple changes but easy to make errors in - hopefully there won't be anything we both miss though! |
|
yes both works (status_id / activity_status_id). I feel the code takes as field name or fields unique name defined in |
|
Ah cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes notice error when trying to save activity and viewing list of activity in Activity tab.
Before
After
No error.
Technical Details
This PR fixes the notice error of using deprecated function. I have replaced it with CRM_Core_PseudoConstant::getKey() method to retrieve value of option values.