CRM-19933 proposed fix for import wiping out preferred comm method (possibly CRM-20035 too) #10731
Conversation
eileenmcnaughton
force-pushed
the
pref_comm
branch
from
2e5d98c to
2094aae
Compare
eileenmcnaughton
changed the title
|
Did style fix and tested CRM-19933 and CRM-20035, working fine. @eileenmcnaughton are you going to add unit test for it? |
|
Seems like 2 test build failures is related. |
eileenmcnaughton
force-pushed
the
pref_comm
branch
from
e726edb to
ec0e05f
Compare
|
There is some nasty magic in the deprecated formatArrayKeys that we need to keep to keep behaviour unchanged. Since that is not the main part of the PR I'm reverting that change |
eileenmcnaughton
force-pushed
the
pref_comm
branch
from
ec0e05f to
37f7ae8
Compare
|
@monishdeb I have added a test to ensure it is possible to set this to null via the api (which the form layer doesn't use but it does share the relevant code. In doing so I found some duplicate handling in the api which was causing problems with separators being appended at the api layer and in the BAO. I had to remove that to get the null test to pass. Can you re-review if these tests pass? |
|
Sure |
|
Tested for CRM-19933 and CRM-20035, working fine. |
@lcdservices just took a quick look at the prefferred_communication_method issue & it appears to me that we need to stop the BAO setting it & then force-set it on the 2 forms that display it for editing (ie QF is trimming it)
No unit test as yet :-(