Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20945 Remove underline on active pager step #10723

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Jul 22, 2017

ping @colemanw @seanmadsen does this make sense to both of you?


@colemanw
Copy link
Member

@seamuslee001 can you do a screenshot to show the difference?

@seamuslee001
Copy link
Contributor Author

@colemanw before
before pr crm-20945
After
after pr crm-20945

@colemanw
Copy link
Member

That change is almost too subtle to notice. My design eye would want the active option to look like a depressed button. Something obvious.

@seamuslee001
Copy link
Contributor Author

@colemanw i have tried making the active one look bit more darker whilst still keeping in line with the rest see the below screen shot. I also thought of having a white square box behind it but i felt that would break the look a bit too much
after pr crm-20945 latest

@colemanw colemanw merged commit 9c64494 into civicrm:master Jul 25, 2017
@seamuslee001 seamuslee001 deleted the CRM-20945 branch July 25, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants