Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method cannot be a protected static #10404

Merged
merged 2 commits into from
May 29, 2017
Merged

Conversation

chrisfromredfin
Copy link
Contributor

When called from CRM/Event/Form/Registration/AdditionalParticipant.php, the method getRegistrationContactID may not be protected, or the call fails.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@totten
Copy link
Member

totten commented May 23, 2017

civicrm-builder, ok to test

@totten
Copy link
Member

totten commented May 23, 2017

Thanks for submitting, @chrisfromredfin!

If you drill-down on the red "x", it reports a style issue: "Visibility must be declared on method "getRegistrationContactID"". Maybe mark the function public?

@alexmarketaccess
Copy link

alexmarketaccess commented May 29, 2017

Updated line 91 in (using Joomla):
administrator/components/com_civicrm/civicrm/CRM/Event/Form/Registration/Register.php
to
public static function getRegistrationContactID($fields, $self, $isAdditional) {

and that has resolved the issue for me on version 4.7.19

@totten totten merged commit 6b691b6 into civicrm:master May 29, 2017
@totten
Copy link
Member

totten commented May 29, 2017

Thanks @chrisfromredfin @alexmarketaccess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants