-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-20563 change fatal error message #10340
Conversation
CRM-10293 and CRM-20563
I thought this might be a PR I could handle but thought maybe modifying the wording from "when this occured" to "what action you were performing when this occured". |
I'm fine with that change. Please go ahead. As an aside, I'm not sure if we should be commenting in GitHub or JIRA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest following wording change (approved by Stoob):
"Sorry, due to an error, CiviCRM is unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred."
@kngs I just got an important comment. "CiviCRM" is not appropriate for people who package the software under another name: PowerBase, BlueBird, etc. Please replace "CiviCRM is" with "we are" |
I have made the final text change incorporating your suggestions @kngs and others. ready for merge |
Hi Stoob, Hi Stoob, I'm sorry you had to make the change. I am still learning the PR system and was going to reach out to Ali, who walked me through my first PR, to make the changes. I also was trying to do a pre and post test; amazing how challenging it is to get that message when you want it!! I thought this would be an easy one but I still have a lot to learn. Is there anything else I need to do? Again my apologies for taking so long (still trying to catch up with work and life after the conference ). Karen Do I still need to test or submit!?!? |
Looks like @Stoob approved this to merge and as a wording change that is good enough for me! |
CRM-10293 and CRM-20563