Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20549 no limit on event permission check api call #10325

Merged
merged 2 commits into from
May 11, 2017
Merged

CRM-20549 no limit on event permission check api call #10325

merged 2 commits into from
May 11, 2017

Conversation

lcdservices
Copy link
Contributor

@lcdservices lcdservices commented May 10, 2017 •
edited by civicrm-builder
Loading

@mfb
Copy link
Contributor

mfb commented May 10, 2017

You should also add 'options' => array('limit' => 0), up above in getLocationEvents so it's possible to list locations for more than 25 events.

@lcdservices
Copy link
Contributor Author

agreed and done.

@mfb mfb mentioned this pull request May 10, 2017
Closed
@seancolsen
Copy link
Contributor

Reviewing this now

JoeMurray
JoeMurray reviewed May 10, 2017
View reviewed changes
Copy link
Contributor

@JoeMurray JoeMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay. @monishdeb please test on cfis site and merge if it works.

@seamuslee001
Copy link
Contributor

This makes sense to me

@eileenmcnaughton eileenmcnaughton merged commit 3ba97a2 into civicrm:master May 11, 2017
@eileenmcnaughton
Copy link
Contributor

I'm merging this as I know it was tested by @mfb already - & discussed on MM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeMurray JoeMurray JoeMurray left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcdservices @mfb @seancolsen @seamuslee001 @eileenmcnaughton @JoeMurray @civicrm-builder