NFC remove some unused variables. #10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is never used and without it the others are not required either. This is probably copy & paste from other functions that has not been made to work, but I don't think leaving non-functional code there is a good step towards identifying & fixing whatever problem exists
jitendrapurohit
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is never used and without it the others are not required either.
This is probably copy & paste from other functions that has not been made to work,
but I don't think leaving non-functional code there is a good step towards
identifying & fixing whatever problem exists.
$hasLocationTypes is also unused & $columnKey = ''; is immediately overwritten. There are some more in this file still :-( but trying to keep scope small & easy to read / review