CRM-20452: Fatal Error on saving Organisation Info when geocoding is …

[jitendrapurohit]

…enabled https://issues.civicrm.org/jira/browse/CRM-20452

[xurizaemon]

@jitendrapurohit do you know we have a special function to handle the weirdness that is CiviCRM thinking the four letters "null" actually is a special form of NULL?

See CRM_Utils_System::isEmpty()

[xurizaemon]

If I ran into this, I would want to know why state_province_id='null' before merging this PR.

[seamuslee001]

I think it is explained in the Ticket I think it is when you deselect the state from an address

[xurizaemon]

Thanks. IMO that's incorrect behaviour of the form then - it shouldn't be sending 'null' as a string, surely? Weirdness! The state province ID should conform to an integer or literal null, not the string ... unless there's a good reason to tolerate the other. /opinion

[jitendrapurohit]

Reason for not using isNull - (we don't have isEmpty() :-(), is what I thought to check before, but that function only works if the key is actually present in the array and throws notices when it is not. Eg:

$var = array('key' => 'null');
if (!CRM_Utils_System::isNull($var['key'])) {
  CRM_Core_Error::Debug('Not Null', $var);
}

checks correctly and all seems to be working fine. Now, if we don't get this key:

$var = array();
if (!CRM_Utils_System::isNull($var['key'])) {
  CRM_Core_Error::Debug('Not Null', $var);
}

will throw a notice Notice: Undefined index: key since the key is not present and check of isset() is done after param is entered into isNull() function.

'null' value is being set at this point https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/Address.php#L319 to fix CRM-3393. Also, it is a very minor change needed, hence proceeded with a simple check other than manipulating 'null' to an empty string and check for all remaining scenarios.

[monishdeb]

Replicated the issue, as per the steps mentioned in the issue description. The patch fixes the issue for Google and Yahoo gecode provider.