CRM-20419 jQuery.isEmptyObject misused

[agh1]

This fixes a bunch of places where $.isEmptyObject() is used on arrays and strings. The method's documentation is clear that it may yield inconsistent results when used on anything other than a basic object. In practice, at least some Joomla sites have had problems where CRM.$.isEmptyObject() returns false on an empty array or string despite returning true in most other environments.

This replaces all instances of $.isEmptyObject() in the codebase aside from the couple that actually evaluate objects.

---

• CRM-20419: Profile selector broken on event registration (some version/CMS/browser combos)

[eileenmcnaughton]

@colemanw one for you to check?

[lcdservices]

Tested this PR and confirmed it fixes the problem.

[eileenmcnaughton]

@lcdservices do you understand the code well enough to say that it is also 'safe' to merge? I'm not familiar with it :-(

[lcdservices]

I did a little reading and using .length seems to be an acceptable (and sometimes recommended) alternative to .isEmptyObject() to avoid the strict nature of the latter. so I think this is safe to merge.

[seamuslee001]

Just noting this is causing a regression on dmaster http://dmaster.demo.civicrm.org/civicrm/admin/contribute/custom?reset=1&action=update&id=1

[colemanw]

Thanks @seamuslee001 - I've submitted #10331

[agh1]

Thanks @seamuslee001 and @colemanw!