Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export in typings #298

Merged
merged 1 commit into from
Mar 2, 2019
Merged

fix export in typings #298

merged 1 commit into from
Mar 2, 2019

Conversation

nucleartux
Copy link
Contributor

No description provided.

@ajbouh
Copy link

ajbouh commented Feb 28, 2019

This fixes it for me too – any word on when this might be part of a new release?

@MatthewHerbst
Copy link
Contributor

MatthewHerbst commented Mar 1, 2019

This will fix #297

cc @lencioni / @trotzig

@rosskevin
Copy link
Contributor

rosskevin commented Mar 1, 2019

Thanks @nucleartux. Change looks correct and typechecks locally.

This fixes a typing error introduced by @realityking in 0876d16#diff-b52768974e6bc0faccb7d4b75b162c99

Just a note, in-repo types cause big problems for downstream ts users if they are incorrect - our only solution is to lock it back to an old version. Since this is a needed bug fix for ts users, can we get a merge/patch release soon?

Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lencioni lencioni merged commit 7d7460b into civiccc:master Mar 2, 2019
@nucleartux nucleartux deleted the patch-1 branch March 2, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants