Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to better understand log message in tests #255

Merged
merged 1 commit into from
Jun 11, 2018

Commits on Jun 10, 2018

  1. Add message to better understand log message in tests

    We have a test that verifies that an error is thrown as part of
    rendering a waypoint with more than one child. Even though we take
    measures to prevent the error from leaking outside the test itself,
    Karma picks it up and prints a confusing log:
    
    ERROR: 'The above error occurred in the <Waypoint> component:
        in Waypoint
        in div
    
    No error is logged above that line, which makes it hard to understand.
    
    While it's probably possible to get rid of that line some other way, I
    opted for a simple solution to begin with, simply logging something that
    makes it A) easier to ignore B) easier to find the offending test case.
    trotzig committed Jun 10, 2018
    Configuration menu
    Copy the full SHA
    04ae3a0 View commit details
    Browse the repository at this point in the history