Always remove window resize event listener

As eagle-eyed @jeffkole pointed out [0], we always want to remove this event listener, even if the scrollableAncestor does not exist. [0]: #20 (comment)
civiccc · Aug 17, 2015 · 0443d22 · 0443d22
1 parent ec5b866
commit 0443d22
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 - Add event object and scope to onEnter/onLeave calls
 - Allow React 0.14.0-beta peerDependency
+- Always remove window resize event listener
 
 ## 1.0.1
 

diff --git a/src/waypoint.jsx b/src/waypoint.jsx
@@ -14,8 +14,6 @@ const Waypoint = React.createClass({
     threshold: PropTypes.number,
   },
 
-  _wasVisible: false,
-
   /**
    * @return {Object}
    */
@@ -46,10 +44,12 @@ const Waypoint = React.createClass({
       //
       //   Cannot read property 'removeEventListener' of undefined
       this.scrollableAncestor.removeEventListener('scroll', this._handleScroll);
-      window.removeEventListener('resize', this._handleScroll);
     }
+    window.removeEventListener('resize', this._handleScroll);
   },
 
+  _wasVisible: false,
+
   /**
    * Traverses up the DOM to find an ancestor container which has an overflow
    * style that allows for scrolling.