fix: Drop :8080 port suffix from S3 how-to guides #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me as well. |
|
Split the one commit into two since we're having to handle this change separately for the S3 and Swift APIs. Tracking the Swift-related update in #265. |
fghaas
changed the title
Now that all our object storage services are listening on the regular HTTPS port (443), we no longer need to list the :8080 suffix in our how-to guides for S3. We still do need to keep the suffix in the how-to guides for Swift, since our object-storage endpoints in our service catalogs still do contain the :8080 suffix.
|
@colder-is-better This will need a re-review please, due to having been rebased on current |
colder-is-better
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all our object storage services are listening on the regular HTTPS port (443), we no longer need to list the
:8080suffix in our how-to guides for S3.We still do need to keep the suffix in the how-to guides for Swift, since our
object-storageendpoints in our service catalogs still do contain the:8080suffix.