Skip to content

add default named_modules_to_munmap variable #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
city96 merged 2 commits into from
Nov 7, 2025
Merged

add default named_modules_to_munmap variable #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f5a547
add default named_modules_to_munmap variable
rattus128 Nov 6, 2025
3ea485c
nodes: carry the mmap_released state through a clone()
rattus128 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,14 @@ def unpatch_model(self, device_to=None, unpatch_weights=True):

def pin_weight_to_device(self, key):
op_key = key.rsplit('.', 1)[0]
if self.named_modules_to_munmap is not None and op_key in self.named_modules_to_munmap:
if not self.mmap_released and op_key in self.named_modules_to_munmap:
# TODO: possible to OOM, find better way to detach
self.named_modules_to_munmap[op_key].to(self.load_device).to(self.offload_device)
del self.named_modules_to_munmap[op_key]
super().pin_weight_to_device(key)

mmap_released = False
named_modules_to_munmap = {}

def load(self, *args, force_patch_weights=False, **kwargs):
if not self.mmap_released:
Expand Down Expand Up @@ -115,7 +116,7 @@ def load(self, *args, force_patch_weights=False, **kwargs):
# TODO: possible to OOM, find better way to detach
m.to(self.load_device).to(self.offload_device)
self.mmap_released = True
self.named_modules_to_munmap = None
self.named_modules_to_munmap = {}

def clone(self, *args, **kwargs):
src_cls = self.__class__
Expand All @@ -125,6 +126,7 @@ def clone(self, *args, **kwargs):
self.__class__ = src_cls
# GGUF specific clone values below
n.patch_on_device = getattr(self, "patch_on_device", False)
n.mmap_released = getattr(self, "mmap_released", False)
if src_cls != GGUFModelPatcher:
n.size = 0 # force recalc
return n
Expand Down