Merged
Conversation
Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
…g bug, fixed import bug and constructor argument order for MessageRouterImpl
thanaParis
requested review from
ChrisWeissmann,
elliot-sabitov and
lydiazcheng
lydiazcheng
approved these changes
Mar 29, 2024
ChrisWeissmann
approved these changes
Apr 2, 2024
Collaborator
ChrisWeissmann
left a comment
ChrisWeissmann
left a comment
There was a problem hiding this comment.
I left some minor feedback. Other than that, looks good to me :)
Signed-off-by: thanaParis <thana.paris@s44.team>
…zontal scaling of citrine Signed-off-by: thanaParis <thana.paris@s44.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alters Subscriptions to be persistent in SQL db, added GET and DELETE CRUD endpoints to api for Subscriptions now that they are db entities.
N.B.: The PUT Subscription was altered to a POST since the requests are not Idempotent (calling the endpoint repeatedly will create many new entries rather than updating the first created, due to the database id being generated in the data layer).