Feature/admin api#53
Merged
thanaParis merged 8 commits intofeature/network-connection-refactorfrom Mar 25, 2024
Merged
Conversation
Signed-off-by: thanaParis <thana.paris@s44.team>
…tConnection Signed-off-by: thanaParis <thana.paris@s44.team>
…ch updates Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
thanaParis
requested review from
ChrisWeissmann,
elliot-sabitov,
joll90 and
lydiazcheng
02_Util/src/centralsystem/networkconnection/WebsocketNetworkConnection.ts
Show resolved
Hide resolved
02_Util/src/centralsystem/networkconnection/WebsocketNetworkConnection.ts
Outdated
Show resolved
Hide resolved
02_Util/src/centralsystem/networkconnection/WebsocketNetworkConnection.ts
Outdated
Show resolved
Hide resolved
thanaParis
changed the base branch from
rc-1.1.0
to
feature/network-connection-refactor
thanaParis
added a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: thanaParis <thana.paris@s44.team>
lydiazcheng
reviewed
Mar 19, 2024
Co-authored-by: lydiazcheng <lydiazcheng@users.noreply.github.com> Signed-off-by: thanaParis <83840862+thanaParis@users.noreply.github.com>
Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
lydiazcheng
reviewed
Mar 22, 2024
…r to ocpp router instead of central system Signed-off-by: thanaParis <thana.paris@s44.team>
Collaborator
Author
Added! |
lydiazcheng
approved these changes
Mar 22, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors MessageRouter as a module:
a) OcppRouter supports a 'admin api', allowing system config to be adjusted for central system, as well as exposing a 'subscription api'
Subscription API:
subscribe a url to receive events - onConnection events, onMessage events, sentMessage events, and onClose events
messageFilter regex string field provided to only match certain messages for onMessage and sentMessage events
This is a diagram of the overall changes in class structure between this pr and the network connection refactor pr -- note the IMessageRouter is the same instance in both WebsocketNetworkConnection and IModuleAPI.
