Merged
Conversation
…onfig Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
Signed-off-by: thanaParis <thana.paris@s44.team>
thanaParis
requested review from
ChrisWeissmann,
elliot-sabitov,
joll90 and
lydiazcheng
Signed-off-by: thanaParis <thana.paris@s44.team>
elliot-sabitov
approved these changes
Mar 11, 2024
lydiazcheng
approved these changes
Mar 11, 2024
Contributor
lydiazcheng
left a comment
lydiazcheng
left a comment
There was a problem hiding this comment.
The code looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring System config:
Aligning with future goal of abstracting away network connection from Central System
a. Certificate module refactored to handle tls/mtls being server-level