Merged
Conversation
…sent the specification Signed-off-by: thanaParis <thana.paris@s44.team>
…ectus never crashes on startup Signed-off-by: thanaParis <thana.paris@s44.team>
…eport flow works intuitively out of the box Signed-off-by: thanaParis <thana.paris@s44.team>
…ing component findOrCreate to avoid warning for unknown attribute Signed-off-by: thanaParis <thana.paris@s44.team>
…e; moving tbc check to after database update so that PENDING status is not removed if device model is unable to load Signed-off-by: thanaParis <thana.paris@s44.team>
joll90
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving device model to use more concise sequelize and better represent the specification: