Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: patch jinja2 for Python 3.10 compat #3

Closed
wants to merge 1 commit into from
Closed

tools: patch jinja2 for Python 3.10 compat #3

wants to merge 1 commit into from

Conversation

qwell
Copy link

@qwell qwell commented Nov 25, 2021

PR-URL: nodejs#40296
Fixes: nodejs#40294
Reviewed-By: Jiawen Geng [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Christian Clauss [email protected]
Reviewed-By: Michaël Zasso [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

PR-URL: nodejs#40296
Fixes: nodejs#40294
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@blattersturm
Copy link

why 12

@qwell
Copy link
Author

qwell commented Dec 2, 2021

why 12

cfx/node-12 is the default branch according to github. Is that not the case? When doing a submodule init, that's the branch that gets checked out.

@blattersturm
Copy link

When doing a submodule init, that's the branch that gets checked out.

Nope, the commit that's referenced is on https://github.com/citizenfx/node/tree/cfx/node-16 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build on Fedora 35 beta using Python 3.10
3 participants