Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gamestate/server): train sync node getters #2983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ehbw
Copy link
Contributor

@Ehbw Ehbw commented Dec 5, 2024

Goal of this PR

Correct CTrainGameStateDataNode for >b2372 and implement several server getter natives for trains

How is this PR achieving the goal

By finishing CTrainGameStateDataNode and correcting the order for >b2372 Originally PR'd alongside server-setter trains (#2322). And implementing getter natives to allow server scripts to take advantage of this with the following natives:

GET_TRAIN_STATE
IS_TRAIN_CABOOSE
DOES_TRAIN_STOP_AT_STATIONS
GET_TRAIN_CRUISE_SPEED
GET_TRAIN_TRACK_INDEX
GET_TRAIN_FORWARD_CARRIAGE
GET_TRAIN_BACKWARD_CARRIAGE
GET_TRAIN_DIRECTION

This PR applies to the following area(s)

FiveM, Server, Natives

Successfully tested on

Game builds: ..

Platforms: Windows

Provided is a resource created to test these new server natives to ensure they work as intended train-servers-node.zip

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 5, 2024
@Ehbw Ehbw force-pushed the feat/train-sync-node-parsing branch from 0b10649 to 6fb8dd9 Compare December 9, 2024 15:52
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant