Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI for PR#3723 #3772

Closed
wants to merge 3 commits into from

Conversation

BenzhengZhang
Copy link
Collaborator

No description provided.

@BenzhengZhang
Copy link
Collaborator Author

BenzhengZhang commented Jul 31, 2024

@tyan0
Copy link
Contributor

tyan0 commented Jul 31, 2024

I could not reproduce the problem.
https://github.com/tyan0/openh264/actions/runs/10181727155/job/28162603960

What differs between your environment and mine?

tyan0 added a commit to tyan0/openh264 that referenced this pull request Aug 4, 2024
This fixes the fuzzing test failure.

Addresses: cisco#3772
tyan0 added a commit to tyan0/openh264 that referenced this pull request Aug 4, 2024
This fixes the fuzzing test failure.

Addresses: cisco#3772
(cherry picked from commit b13b201)
@tyan0
Copy link
Contributor

tyan0 commented Aug 4, 2024

I could reproduce the issue using artifact in https://github.com/cisco/openh264/actions/runs/10176042462/artifacts/1763247810

This issue is due to a typo in WelsReorderRefList2(). My bug_fix_2 branch has been updated with this fix.

@tyan0 tyan0 mentioned this pull request Aug 4, 2024
tyan0 added a commit to tyan0/openh264 that referenced this pull request Aug 4, 2024
This fixes the fuzzing test failure.

Addresses: cisco#3772
BenzhengZhang pushed a commit that referenced this pull request Aug 5, 2024
* Enable ReorderRefList2() which was added by the commit 1b8caef.

... and fix trivial issue of that function. This solves the some
frame decode error.

* Add workaround for frame decode error due to emulation byte.

* Fix a bug which seems due to a typo in WelsReorderRefList2()

This fixes the fuzzing test failure.

Addresses: #3772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants