Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc CI updates #3694

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −6
Open

Misc CI updates #3694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c26c68
ci: Reenable -Werror testing on mingw targets
mstorsjo Nov 8, 2023
950f75d
test: Don't use sprintf, use snprintf instead
mstorsjo Nov 8, 2023
c8d3011
ci: Add a build configuration, testing building for iOS
mstorsjo Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,8 @@ jobs:
- run: c++ --version
- run: make gmp-bootstrap
- run: make gtest-bootstrap
# disable Werror on gcc 12 until #3533 is fixed.
#- run: CFLAGS=-Werror make -j$(nproc) all plugin test
- run: make -j$(nproc) all plugin test
#- run: meson builddir --werror
- run: meson builddir
- run: CFLAGS=-Werror make -j$(nproc) all plugin test
- run: meson builddir --werror
- run: ninja -C builddir -v
- run: meson test -C builddir -v

Expand Down Expand Up @@ -117,6 +114,15 @@ jobs:
- run: c++ --version
- run: CFLAGS=-Werror make -j$(sysctl -n hw.ncpu) ARCH=arm64

ios-cross-arm64:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- run: make gmp-bootstrap
- run: make gtest-bootstrap
- run: c++ --version
- run: CFLAGS=-Werror make -j$(sysctl -n hw.ncpu) OS=ios ARCH=arm64

fuzzing:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion test/api/simple_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ int main (int argc, char** argv) {

#if (defined(ANDROID_NDK)||defined(APPLE_IOS)||defined(WINDOWS_PHONE))
char xmlPath[1024] = "";
sprintf (xmlPath, "xml:%s", argv[1]);
snprintf (xmlPath, sizeof(xmlPath), "xml:%s", argv[1]);
::testing::GTEST_FLAG (output) = xmlPath;
#endif
::testing::InitGoogleTest (&argc, argv);
Expand Down