Use WelsSnprintf instead of direct snprintf in tests #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of MSVC before 2015 lack snprintf; within the codec codebase
itself, this is wrapped into WelsSnprintf. Within the testcases, there
were no uses of snprintf previously, only sprintf.
We could of course decide to stop caring about older versions of
MSVC, but so far, those versions have still worked just fine.
However, that requires changes to the build files for Windows Phone
("make OS=msvc-wp"), which currently expect to be built with MSVC 2013.
Define NOMINMAX before including windows.h, to avoid windows.h
breaking std::min in test code.
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of MSVC before 2015 lack snprintf; within the codec codebase itself, this is wrapped into WelsSnprintf. Within the testcases, there were no uses of snprintf previously, only sprintf.
We could of course decide to stop caring about older versions of MSVC, but so far, those versions have still worked just fine. However, that requires changes to the build files for Windows Phone ("make OS=msvc-wp"), which currently expect to be built with MSVC 2013.
Define NOMINMAX before including windows.h, to avoid windows.h breaking std::min in test code.