Fix off by one regression in decoder (#3704)

Fix iPicBuffIdx bounds check introduced in commit 986bd65 and allow 0 as an index value. This fixes Big_Buck_Bunny_720_10s_30MB.mp4 playback with gst-play-1.0.
cisco · Dec 4, 2023 · fd66e67 · fd66e67
1 parent 34a0d2d
commit fd66e67
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/codec/decoder/plus/src/welsDecoderExt.cpp b/codec/decoder/plus/src/welsDecoderExt.cpp
@@ -1136,7 +1136,7 @@ void CWelsDecoder::ReleaseBufferedReadyPictureReorder (PWelsDecoderContext pCtx,
       m_sPictInfoList[m_sReoderingStatus.iPictInfoIndex].iPOC = IMinInt32;
       int32_t iPicBuffIdx = m_sPictInfoList[m_sReoderingStatus.iPictInfoIndex].iPicBuffIdx;
       if (pPicBuff != NULL) {
-        if (iPicBuffIdx > 0 && iPicBuffIdx < pPicBuff->iCapacity)
+        if (iPicBuffIdx >= 0 && iPicBuffIdx < pPicBuff->iCapacity)
         {
             PPicture pPic = pPicBuff->ppPic[iPicBuffIdx];
             --pPic->iRefCount;