Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

make: fix run ctrl-c #138

Merged
merged 1 commit into from
Apr 17, 2024
Merged

make: fix run ctrl-c #138

merged 1 commit into from
Apr 17, 2024

Conversation

bonifaido
Copy link
Contributor

@bonifaido bonifaido commented Apr 16, 2024 •
edited
Loading

Description

Because of the messed up while sleep loop in #137 we had to Ctrl+C twice to stop make run.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bonifaido bonifaido self-assigned this Apr 16, 2024
@bonifaido bonifaido marked this pull request as ready for review April 16, 2024 17:20
@bonifaido bonifaido requested a review from a team as a code owner April 16, 2024 17:20
@bonifaido bonifaido merged commit cda0e84 into main Apr 17, 2024
1 check passed
@bonifaido bonifaido deleted the run-ctrl-c-fix branch April 17, 2024 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baluchicken baluchicken baluchicken approved these changes

Assignees

@bonifaido bonifaido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonifaido @baluchicken