Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

fix loopback detection #134

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix loopback detection #134

merged 1 commit into from
Apr 9, 2024

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented Apr 9, 2024 •
edited
Loading

Description

I made a mistake, trusted Golang's IsLoopback() on the Addr level, but it works correctly only on the IP level. Fix of fix: #133

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bonifaido bonifaido self-assigned this Apr 9, 2024
@bonifaido bonifaido marked this pull request as ready for review April 9, 2024 09:41
@bonifaido bonifaido requested a review from a team as a code owner April 9, 2024 09:41
@bonifaido bonifaido merged commit 54c1b8c into main Apr 9, 2024
1 check passed
@bonifaido bonifaido deleted the IsLoopback-fx branch April 9, 2024 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baluchicken baluchicken baluchicken approved these changes

Assignees

@bonifaido bonifaido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonifaido @baluchicken