Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

br_sslio_close fix #57

Merged
merged 4 commits into from
Sep 19, 2023
Merged

br_sslio_close fix #57

merged 4 commits into from
Sep 19, 2023

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented Sep 14, 2023

Description

The return value of this method is the opposite of the documented value.
Also we need to close our side only on the user space close calls, and not on shutdown.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bonifaido bonifaido self-assigned this Sep 14, 2023
@bonifaido bonifaido force-pushed the close-fix branch 2 times, most recently from 873da4e to 5aa3625 Compare September 15, 2023 13:19
@bonifaido bonifaido marked this pull request as ready for review September 19, 2023 09:12
@bonifaido bonifaido requested a review from a team September 19, 2023 09:12
@bonifaido bonifaido merged commit d73eae3 into main Sep 19, 2023
1 check passed
@bonifaido bonifaido deleted the close-fix branch September 19, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants