Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

socket: fixes around camblet_get/setsockopt and recvmsg waiting and other things #209

Merged
merged 22 commits into from
Apr 15, 2024

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented Apr 9, 2024

Description

Original getsockopt restoration in module exit was missing (interesting situations could occur after module unload...), but from now on it is not needed since the overwrite is socket local.

Fixing tcp_connection_context memory placing issue in camblet_setsockopt.

Fix for CPU hog read waits.

Added test for Camblet sockopt functions.

Check the commits for all the fixes.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bonifaido bonifaido self-assigned this Apr 9, 2024
@bonifaido bonifaido changed the title socket: save and restore original tcp_getsocktopts socket: camblet_getsockopt can stay proto local instead of global Apr 9, 2024
@bonifaido bonifaido changed the title socket: camblet_getsockopt can stay proto local instead of global socket: camblet_getsockopt can stay sock local instead of global Apr 9, 2024
@bonifaido bonifaido changed the title socket: camblet_getsockopt can stay sock local instead of global socket: camblet_getsockopt can stay sock local instead of global and other fixes Apr 10, 2024
@bonifaido bonifaido force-pushed the getsockopt_restore branch from 69bdc9d to e5f9e54 Compare April 10, 2024 07:43
@bonifaido bonifaido force-pushed the getsockopt_restore branch from e5f9e54 to c29c22f Compare April 10, 2024 11:37
@bonifaido bonifaido changed the title socket: camblet_getsockopt can stay sock local instead of global and other fixes socket: fixes around camblet_get/setsockopt and recvmsg waiting and other things Apr 12, 2024
@bonifaido bonifaido force-pushed the getsockopt_restore branch from 56a6901 to f7be2b3 Compare April 12, 2024 09:50
@bonifaido bonifaido force-pushed the getsockopt_restore branch from df8c94f to 43d78ee Compare April 12, 2024 13:08
@bonifaido bonifaido marked this pull request as ready for review April 12, 2024 13:12
@bonifaido bonifaido requested a review from a team as a code owner April 12, 2024 13:12
@bonifaido bonifaido force-pushed the getsockopt_restore branch from 0e26391 to fd5b1ee Compare April 12, 2024 14:01
src/socket.c Outdated Show resolved Hide resolved
src/socket.c Outdated Show resolved Hide resolved
src/socket.c Outdated Show resolved Hide resolved
src/socket.c Outdated Show resolved Hide resolved
baluchicken
baluchicken previously approved these changes Apr 15, 2024
test/sockopt.c Outdated Show resolved Hide resolved
Co-authored-by: Balint Molnar <[email protected]>
@bonifaido bonifaido enabled auto-merge (squash) April 15, 2024 14:00
@bonifaido bonifaido disabled auto-merge April 15, 2024 14:02
@bonifaido bonifaido merged commit be5041f into main Apr 15, 2024
5 checks passed
@bonifaido bonifaido deleted the getsockopt_restore branch April 15, 2024 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants